Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing static lib name #55

Closed
utoni opened this issue Jul 9, 2018 · 2 comments
Closed

confusing static lib name #55

utoni opened this issue Jul 9, 2018 · 2 comments

Comments

@utoni
Copy link
Contributor

utoni commented Jul 9, 2018

Hello (.*),

Currently, I'm testing ulfius if it is usable for my project. But before, I need to port it to OpenWrt.
During my first steps I tried to fast build a usable static lib. After the build, my static lib was named `liblibulfius.a' which is a bit confusing.

The problematic line in CMakeLists.txt:
set_target_properties(ulfius_static PROPERTIES OUTPUT_NAME libulfius)

On Unix/Linux CMAKE_SHARED_LIBRARY_PREFIX_lang defaults to `lib'.

So replacing
set_target_properties(ulfius_static PROPERTIES OUTPUT_NAME libulfius)
with
set_target_properties(ulfius_static PROPERTIES OUTPUT_NAME ulfius)
should do the job.

After the first look I'm quite optimistic that it will be usable for my project.

@babelouest
Copy link
Owner

Hello @lnslbrty ,

Thanks for pointing out, I was probably not careful enough when I tested the static builds...

It seems that there is the exact same problem in orcania and hoel but not in yder... I'll fix this soon in the master branches.

Cheers

babelouest added a commit to babelouest/orcania that referenced this issue Jul 10, 2018
babelouest added a commit to babelouest/hoel that referenced this issue Jul 10, 2018
@babelouest
Copy link
Owner

Done, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants