Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: Align PKGCONF_REQ_PRIVATE required versions #108

Merged
merged 1 commit into from Apr 3, 2019
Merged

CMakeLists: Align PKGCONF_REQ_PRIVATE required versions #108

merged 1 commit into from Apr 3, 2019

Conversation

laf0rge
Copy link
Contributor

@laf0rge laf0rge commented Apr 3, 2019

The minimum version requirements are a bit odd: At build time of
ulfius, libmicrohttpd ">= 0.9.51" is sufficient, but then a pkg-config
file is installed stating "PKGCONF_REQ_PRIVATE > 0.9.51", i.e.
explicitly excluding 0.9.51 itself. The same is the case with gnutls
and libmicrohttpd 0.9.53 in case of websockets.

On the other hand, CPACK_DEBIAN_PACKAGE_DEPENDS again states ">=",
so we had two instances where ">=" was sufficient, but only one where
">" was required.

This matters on Debian stretch, where exactly version 0.9.51 of
libmicrohttpd is packaged and hence ulfius builds and gets packaged,
but then one cannot build any applications against ulfius.

The minimum version requirements are a bit odd:  At build time of
ulfius, libmicrohttpd ">= 0.9.51" is sufficient, but then a pkg-config
file is installed stating "PKGCONF_REQ_PRIVATE > 0.9.51", i.e.
explicitly excluding 0.9.51 itself.  The same is the case with gnutls
and libmicrohttpd 0.9.53 in case of websockets.

On the other hand, CPACK_DEBIAN_PACKAGE_DEPENDS again states ">=",
so we had two instances where ">=" was sufficient, but only one where
">" was required.

This matters on Debian stretch, where exactly version 0.9.51 of
libmicrohttpd is packaged and hence ulfius builds and gets packaged,
but then one cannot build any applications against ulfius.
@laf0rge
Copy link
Contributor Author

laf0rge commented Apr 3, 2019

would be great to tag a patch release (2.5.3.1 or 2.5.4) from 2.5.3 including this patch. I also have a similar patch against 2.5.2 available.

@babelouest
Copy link
Owner

Hello @laf0rge ,

Thanks for the pull request. Although the current working branch is 2.6, I will make the change there instead.

I would rather not release Ulfius 2.5.4 just for this, since Ulfius 2.6 is on the tracks.
Can I ask why you need a new release?

@laf0rge
Copy link
Contributor Author

laf0rge commented Apr 3, 2019 via email

@babelouest
Copy link
Owner

babelouest commented Apr 3, 2019

I agree, since Ulfius 2.5 is now in Debian Buster, the branch 2.5 will live a long life. Sometimes I forget about long term support.

I'll take the opportunity to backport some changes from 2.6 though, then I'll release Ulfius 2.5.4 with your changes.

@babelouest babelouest merged commit b69f7ad into babelouest:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants