check if client certificate verification succeed #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnutls_certificate_verify_peers2() returns GNUTLS_E_SUCCESS (0) even in case of certificate verification errors. The client_cert_status parameters must be checked as noticed in gnutls documentation (see [1]). This patch adds this check and goes in error branch. Without this check you can accept a non-trusted certificate and MITM attacks can be done. [1] https://gnutls.org/manual/gnutls.html#gnutls_005fcertificate_005fverify_005fpeers2
|
I've found that the framework.c test is also broken as the provided server certificate is self-signed, and not signed by the provided CA certificate as it should be. |
|
Thanks, although the tests full with this fix. I need verify that before merging, but thanks a lot for pointing out the bug! |
|
@babelouest I suggest you keep the current self-signed certificate as a "wrong" certificate to add a new test for the case of non-trusted client certificate. |
|
I will improve the ca tests in |
babelouest
added a commit
that referenced
this pull request
Jan 13, 2020
The certificate tests were broken and I didn't know it until #154, add more test cases to avoid that in the future, also generate key files and cert files on demand to make sure the tests will succeed in the far future
|
Tests fixed and PR merged. Merci beaucoup @yomgui1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnutls_certificate_verify_peers2() returns GNUTLS_E_SUCCESS (0) even in case of certificate verification errors.
The client_cert_status parameters must be checked as noticed in gnutls documentation (see [1]).
This patch adds this check and goes in error branch.
Without this check you can accept a non-trusted certificate and MITM attacks can be done.
[1] https://gnutls.org/manual/gnutls.html#gnutls_005fcertificate_005fverify_005fpeers2