setup.py: migrate away from distutils. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils is deprecated and going to be removed from Python 3.12. This change updates setup.py to make use of the setup function from setuptools instead, per [PyPA recommendations]. [PyPA recommendations]: https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html#prefer-setuptools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
distutils is deprecated and going to be removed from Python 3.12. This change updates setup.py to make use of the setup function from setuptools instead, per PyPA recommendations.
Fixes (issue)
Type of change
How Has This Been Tested?
I have run the Debian package building procedure, then the test suite against the packaged result, and it shown no regressions. Basically this can be replicated by installing the module and running the test suite against the installment.
Checklist:
I have commented my code, particularly in hard-to-understand areasChange is one line, so adding comments around would probably be dead weight.
I have made corresponding changes to the documentationDocumentation didn't refer to distutils initially, no changes required I think.
I have added tests that prove my fix is effective or that my feature worksThere was no clear point, or way, for adding a test for this particular change.