Update translations #250
Merged
Update translations #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I have merged the translations. However, please use weblate for the next time when doing translations. |
|
Yes sure but I had to make po files up to date before doing anything. So I updated French translations at the same time. But next time if needed I'm going to use Weblate for sure. I'm already using it for other apps and elementary OS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I figured out that some translations weren't working. Also appdata wasn't appearing translated in the AppCenter. This PR should fix theses issues.
I tried to build the app and I don't understand why but the search placeholder "Search by Title, Author and Tags" and the "Open" string on the welcome view won't be translated.
I added missing translations, updated translation files and updated French translations 馃槃
This PR is ready for review