Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show breast side on timeline, resolve #39 #45

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

Xandersoft
Copy link
Contributor

  • add 2 Images with BR BL
  • adds the differentiation between the 3 states on timeline

@MrApplejuice MrApplejuice linked an issue Sep 12, 2023 that may be closed by this pull request
@MrApplejuice
Copy link
Collaborator

Hey Xandersoft,

Thank you very much for contributing! I will have time this weekend most likely to give this an in-depth look.

This will address #39.

@MrApplejuice
Copy link
Collaborator

Finally got around to look at the PR! Looks good. I hope you do not mind if I combine your image:

image

With the existing pictographic breast image so that the iconography is a bit equal. I think I would prefer that. Other than that, functional and looks good!

@MrApplejuice MrApplejuice merged commit 91fa19d into babybuddy:master Sep 30, 2023
@MrApplejuice
Copy link
Collaborator

Took me quite some time to get back at this. Big thanks for the contribution.

I tried to make a combination of the L/R logos you created with the breast. Took some time to get it right so that this renders properly in small sizes. This is what I came up with.

To be fair: I only think that this is a tiny tiny improvement but at least the icons are in there which will ease translations in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show which breast was fed after stopping feeding timer
2 participants