-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New, cleaner, coroutine-based client implementation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnecting" dialog cancelable, add "connecting" strings to strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started work on a new babybuddy-api client leveraging
retrofit
andjackson
for automated data binding!The new client uses generics-based query functions to directly query data types via the client in coroutine functions. This makes it a lot easier to configure and support new data bindings for which, up until now, I had to hand-spin the serializers and deserializers.
A huge milestone that will be reached after this is done, is that the timeline will support showing all current events and measurements/what-have-you that are supported in baby buddy. Not editing, just showing!
Current state
ChildEventHistoryLoader
to use the new v2clientgetEntries
. Reveals a deeper problem: How to implement exponential backoff and the "spinning waiter" now?TimelineObserver
can be removed!Fix slight bug where observers are not cleaned up correctly after booting the app and switching from child=1 to child=2 for example. After the initial load, everything works fine though. Probably related to the ViewPager-life cycle.