Skip to content

Commit

Permalink
Refactor core forms test base class
Browse files Browse the repository at this point in the history 
The extra child added in the base classes caused failures with the `test_child_with_one_child` test.
  • Loading branch information
@cdubz
cdubz committed Jan 30, 2020
1 parent 4a970b4 commit 8d399dd
Showing 1 changed file with 29 additions and 24 deletions.
53 changes: 29 additions & 24 deletions core/tests/tests_forms.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ class InitialValuesTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(InitialValuesTestCase, cls).setUpClass()
cls.child_two = models.Child.objects.create(
first_name='Child',
last_name='Two',
birth_date=timezone.localdate()
)
cls.timer = models.Timer.objects.create(
user=cls.user,
start=timezone.localtime() - timezone.timedelta(minutes=30)
Expand All @@ -71,16 +66,27 @@ def test_child_with_one_child(self):
self.assertEqual(page.context['form'].initial['child'], self.child)

def test_child_with_parameter(self):
child_two = models.Child.objects.create(
first_name='Child',
last_name='Two',
birth_date=timezone.localdate()
)

page = self.c.get('/sleep/add/')
self.assertTrue('child' not in page.context['form'].initial)

page = self.c.get('/sleep/add/?child={}'.format(self.child.slug))
self.assertEqual(page.context['form'].initial['child'], self.child)

page = self.c.get('/sleep/add/?child={}'.format(self.child_two.slug))
self.assertEqual(page.context['form'].initial['child'], self.child_two)
page = self.c.get('/sleep/add/?child={}'.format(child_two.slug))
self.assertEqual(page.context['form'].initial['child'], child_two)

def test_feeding_type(self):
child_two = models.Child.objects.create(
first_name='Child',
last_name='Two',
birth_date=timezone.localdate()
)
f_one = models.Feeding.objects.create(
child=self.child,
start=timezone.localtime() - timezone.timedelta(hours=4),
Expand All @@ -89,7 +95,7 @@ def test_feeding_type(self):
method='left breast'
)
f_two = models.Feeding.objects.create(
child=self.child_two,
child=child_two,
start=timezone.localtime() - timezone.timedelta(hours=4),
end=timezone.localtime() - timezone.timedelta(hours=3, minutes=30),
type='formula',
Expand All @@ -102,8 +108,7 @@ def test_feeding_type(self):
page = self.c.get('/feedings/add/?child={}'.format(self.child.slug))
self.assertEqual(page.context['form'].initial['type'], f_one.type)

page = self.c.get('/feedings/add/?child={}'.format(
self.child_two.slug))
page = self.c.get('/feedings/add/?child={}'.format(child_two.slug))
self.assertEqual(page.context['form'].initial['type'], f_two.type)

def test_timer_set(self):
Expand Down Expand Up @@ -133,16 +138,16 @@ def test_timer_stop_on_save(self):
self.assertEqual(self.localtime_string(self.timer.end), params['end'])


class ChildFormsTestCaseBase(FormsTestCaseBase):
class ChildFormsTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(ChildFormsTestCaseBase, cls).setUpClass()
super(ChildFormsTestCase, cls).setUpClass()
cls.child = models.Child.objects.first()

def test_add(self):
params = {
'first_name': 'Child',
'last_name': 'One',
'last_name': 'Two',
'birth_date': timezone.localdate()
}
page = self.c.post('/children/add/', params, follow=True)
Expand Down Expand Up @@ -177,10 +182,10 @@ def test_delete(self):
self.assertContains(page, 'Child entry deleted')


class DiaperChangeFormsTestCaseBase(FormsTestCaseBase):
class DiaperChangeFormsTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(DiaperChangeFormsTestCaseBase, cls).setUpClass()
super(DiaperChangeFormsTestCase, cls).setUpClass()
cls.change = models.DiaperChange.objects.create(
child=cls.child,
time=timezone.localtime(),
Expand Down Expand Up @@ -237,10 +242,10 @@ def test_delete(self):
self.assertContains(page, 'Diaper Change entry deleted')


class FeedingFormsTestCaseBase(FormsTestCaseBase):
class FeedingFormsTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(FeedingFormsTestCaseBase, cls).setUpClass()
super(FeedingFormsTestCase, cls).setUpClass()
cls.feeding = models.Feeding.objects.create(
child=cls.child,
start=timezone.localtime() - timezone.timedelta(hours=2),
Expand Down Expand Up @@ -303,10 +308,10 @@ def test_delete(self):
self.assertContains(page, 'Feeding entry deleted')


class SleepFormsTestCaseBase(FormsTestCaseBase):
class SleepFormsTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(SleepFormsTestCaseBase, cls).setUpClass()
super(SleepFormsTestCase, cls).setUpClass()
cls.sleep = models.Sleep.objects.create(
child=cls.child,
start=timezone.localtime() - timezone.timedelta(hours=6),
Expand Down Expand Up @@ -357,10 +362,10 @@ def test_delete(self):
self.assertContains(page, 'Sleep entry deleted')


class TemperatureFormsTestCaseBase(FormsTestCaseBase):
class TemperatureFormsTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(TemperatureFormsTestCaseBase, cls).setUpClass()
super(TemperatureFormsTestCase, cls).setUpClass()
cls.temp = models.Temperature.objects.create(
child=cls.child,
temperature=98.6,
Expand Down Expand Up @@ -404,10 +409,10 @@ def test_delete(self):
self.assertContains(page, 'Temperature entry deleted')


class TummyTimeFormsTestCaseBase(FormsTestCaseBase):
class TummyTimeFormsTestCase(FormsTestCaseBase):
@classmethod
def setUpClass(cls):
super(TummyTimeFormsTestCaseBase, cls).setUpClass()
super(TummyTimeFormsTestCase, cls).setUpClass()
cls.tt = models.TummyTime.objects.create(
child=cls.child,
start=timezone.localtime() - timezone.timedelta(hours=2),
Expand Down Expand Up @@ -457,7 +462,7 @@ def test_delete(self):
self.assertContains(page, 'Tummy Time entry deleted')


class TimerFormsTestCaseBase(FormsTestCaseBase):
class TimerFormsTestCase(FormsTestCaseBase):
def test_add(self):
params = {
'child': self.child.id,
Expand Down

0 comments on commit 8d399dd

Please sign in to comment.