Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diaper change without wet/solid #426

Closed
myxor opened this issue Apr 1, 2022 · 1 comment · Fixed by #431
Closed

Diaper change without wet/solid #426

myxor opened this issue Apr 1, 2022 · 1 comment · Fixed by #431
Labels
good first issue Good candidates for simple work for first time contributors task Specific non-feature things to do that don't require debugging

Comments

@myxor
Copy link
Contributor

myxor commented Apr 1, 2022

For me it makes sense to add a diaper change event without selecting any of wet and solid types.

We sometimes change the diaper for the child to feel more fresh even though nothing is actually in it.

I would like to still keep track of these changes but currently it is not allowed to add such an event without selecting wet and solid state.

@cdubz
Copy link
Member

cdubz commented Apr 1, 2022

I suppose this seems reasonable enough. Tracking "diaper changes" is really meant more as a proxy for tracking the baby's bodily functions but that doesn't necessarily mean we have to enforce in this way. I'm open to PRs for this but be aware that there may be assumptions made throughout the app about the presence of those fields beyond just there required-ness in the model.

@cdubz cdubz added task Specific non-feature things to do that don't require debugging good first issue Good candidates for simple work for first time contributors labels Apr 1, 2022
myxor added a commit to myxor/babybuddy that referenced this issue Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good candidates for simple work for first time contributors task Specific non-feature things to do that don't require debugging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants