Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No notes found" background doesn't extend to the Tags column #469

Closed
Alberdi opened this issue Jun 3, 2022 · 1 comment
Closed

"No notes found" background doesn't extend to the Tags column #469

Alberdi opened this issue Jun 3, 2022 · 1 comment
Labels
bug Reports of unexpected problems or errors good first issue Good candidates for simple work for first time contributors

Comments

@Alberdi
Copy link
Contributor

Alberdi commented Jun 3, 2022

See picture when opening the Notes list without any note:
Screenshot 2022-06-03 at 20 01 55

It also seems like the presence/absence of that background varies per screen, so we might want to normalize that.
@cdubz
Copy link
Member

cdubz commented Jun 5, 2022

This is set by the colspan attribute in each of the core *_list.html templates (e.g. core/templates/core/note_list.html#L64). Any that are wrong just need to be updated with the correct colspan. They are probably all wrong now because of the tags updates (:

@cdubz cdubz added bug Reports of unexpected problems or errors good first issue Good candidates for simple work for first time contributors labels Jun 5, 2022
cdubz added a commit that referenced this issue Jun 13, 2022
@cdubz
Standardize list class and fix colspans
dbd6f0f 
Fixes #469
@cdubz cdubz closed this as completed in f5ae1a5 Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Reports of unexpected problems or errors good first issue Good candidates for simple work for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alberdi @cdubz