Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solid food option to feeding types #201

Merged
merged 3 commits into from Apr 15, 2021
Merged

Conversation

0x4161726f6e
Copy link
Contributor

I would find this helpful as I coordinate with day care

I would find this helpful as I coordinate with day care
@coveralls
Copy link

coveralls commented Apr 4, 2021

Coverage Status

Coverage remained the same at 99.359% when pulling 7f1db75 on 0x4161726f6e:patch-1 into e6838a0 on babybuddy:master.

@cdubz
Copy link
Member

cdubz commented Apr 4, 2021

Thanks for the PR! I think this makes sense as a small and straightforward change to allow some new variation in the feeding types. This may have some effects on other areas of the application that expect the current options so we’ll need to evaluate that. But tests are passing (the Travis fail appears to be an unrelated issue with the Python 3.8 tests) so that’s a good sign (:

@cdubz cdubz added this to the v1.5.2 milestone Apr 4, 2021
@cdubz cdubz merged commit dadb84e into babybuddy:master Apr 15, 2021
@cdubz
Copy link
Member

cdubz commented Apr 15, 2021

Thanks @0x4161726f6e! This is merged in to master. Will be in a release within the next few weeks or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants