Make form submit full width fixed #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's slightly worse on desktop; ideally this would only occur on mobile, but I think it's more complicated to get that to work within bootstrap, and not necessarily worth it, so I'm in favor of this change. |
|
I don’t think it would be much effort to make this more responsive. This was just the lightest touch approach. I’ll sit on it for a moment. |
|
@cdubz I like the ux on mobile but I'm also on the fence about desktop. I don't think it's terrible but it does feel a bit off. I think if you could split the experience between mobile and desktop that would be perfect. |
Troubleshooting issue with Pipenv Python executable discovery.
cdubz
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231. Alternative to #249.
@lutzky @BenjaminHae @ntrecina interested in your thoughts on this approach (since y'all chimed in on #249 to some extent). Mobile experience seems solid but I'm not sure how I feel about desktop -- the ux is not better there but I also don't think it is worse.