New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Height, Head Circumference, and BMI #360
Add Height, Head Circumference, and BMI #360
Conversation
@daegalus thanks for contributing! I have been hesitant to add anything more than the "weight" and "temperature" measurements stuff but it looks like you've taken a good approach for it here and done an impressive first pass of work. I have approved the workflow runs and there are a few linting issues to be resolved there. I have also approved the Heroku branch deployment so we can see this in action at https://babybuddy-pr-360.herokuapp.com. I ran the For review, I'm traveling right now so not quite sure when I'll be able to really dig in to this. I'll also ping some of the regular contributors/users on Gitter for review/opinions. Re: medical information -- I'm on board to add that as well but lets keep notifications in mind, at least. See #66, #153, #200. See also the discussion in #217. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well a big PR but easy enough to review when its so well done. Thanks!
Just two review comments to look at and the linting issue and this should be good.
NP, I will take care of these now. And I have some ideas on how we can do Notifications now with the current structure, while you guys work on the new generic model design. That way we can get some of these features added before 2.0's rewrite. I would help but I am not familiar with Django, and even if I am a backend/devops engineer, its not something I work in regularly so not familiar with what the idiomatic ways of doing object models is for Python/Django. I live very deep in Go land. |
Oops — #361 just added a migration. You’ll need to update yours to follow that one. |
…ove to separate menu with Weight and Temperature.
6af8174
to
741c6e0
Compare
should be fixed |
also noticed the font doesn't seem to be updating on the Heroku deploy, as the icons for the new menu options aren't there. Might need a hard refresh? |
Looks great! Re: the icons -- when adding new ones it still necessary to run Thanks, @daegalus! |
Closes #191
I am an expecting father, and learned these are expected metrics that get checked at every doctors visit on a newborn. We figure we can track some of these ourselves at home.
I found BabyBuddy its amazing, and will be contributing more (planning to tackle Medicine/Immunizations/Shots next (just tracking, no notifications/alerts). But figured I would get my feed wet with this task.
Changes in this PR:
Measurements
and movedTemperature
andWeight
into that menu, alongside the new measurements.en_GB
.Let me know if I missed anything.