Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual build corrections in readme.md #40

Merged
merged 3 commits into from
May 4, 2018
Merged

manual build corrections in readme.md #40

merged 3 commits into from
May 4, 2018

Conversation

novski
Copy link
Contributor

@novski novski commented May 4, 2018

I figured out some issues in manual build, hope this helps others to build manualy faster...
Session variable is needed on raspberrypi 3+. Allthroug im not shure if it's the best way to go...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 99.569% when pulling d1c4ed3 on novski:master into c42392d on cdubz:master.

@babybuddy babybuddy deleted a comment from coveralls May 4, 2018
@babybuddy babybuddy deleted a comment from coveralls May 4, 2018
@cdubz
Copy link
Member

cdubz commented May 4, 2018

Thanks for the PR.

Interesting note - the sudo -H pip install pipenv command does not work when I tested walking through this on a Pi with a fresh install of raspbian strecth. I wonder if the alias does not work if python2 pip isn't installed at all (it was not in my test environment)?

Anyway, could you push another commit removing the alias pip=pip3 line from step 2 and changing step 3 to sudo -H pip3 install pipenv? I think that is the only place that pip3 is needed. I'll accept this PR with those changes.

@cdubz cdubz merged commit e079c57 into babybuddy:master May 4, 2018
cdubz added a commit that referenced this pull request May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants