Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep history #485

Merged
merged 6 commits into from Jun 28, 2022
Merged

Sleep history #485

merged 6 commits into from Jun 28, 2022

Conversation

DanBeard
Copy link
Contributor

Add a list of sleep totals for the last 7 days. Useful for seeing how well the little ones are sleeping (or not 馃槄 ) . If a sleep session goes over midnight then the duration that is before midnight is added to the start day, and the portion that is after midnight is added to the end day.

Unsure of what noun to use for "sleep" in the dashboard since "nap" has an already established meaning and this counts all sleep sessions, not just naps. Went for the simple noun "sleep"

Relies on #484 .

sleep

@DanBeard DanBeard marked this pull request as draft June 15, 2022 03:01
@DanBeard DanBeard marked this pull request as ready for review June 15, 2022 03:07
@coveralls
Copy link

coveralls commented Jun 15, 2022

Coverage Status

Coverage decreased (-0.04%) to 99.158% when pulling ec8fd98 on DanBeard:sleep_history into c98f6cd on babybuddy:master.

Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small change requests for now. I'll do more testing later.

core/templatetags/duration.py Outdated Show resolved Hide resolved
dashboard/templatetags/cards.py Outdated Show resolved Hide resolved
Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small CR -- otherwise looks good!

dashboard/templates/cards/sleep_recent.html Outdated Show resolved Hide resolved
@cdubz cdubz merged commit 834e763 into babybuddy:master Jun 28, 2022
@cdubz
Copy link
Member

cdubz commented Jun 28, 2022

All good -- thanks!!

@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label Jun 28, 2022
@cdubz cdubz added this to the 1.11.2 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants