New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleep history #485
Merged
Merged
Sleep history #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdubz
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small change requests for now. I'll do more testing later.
cdubz
requested changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more small CR -- otherwise looks good!
cdubz
approved these changes
Jun 28, 2022
All good -- thanks!! |
cdubz
added
the
enhancement
Feature requests or improvements to existing functionality
label
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a list of sleep totals for the last 7 days. Useful for seeing how well the little ones are sleeping (or not 馃槄 ) . If a sleep session goes over midnight then the duration that is before midnight is added to the start day, and the portion that is after midnight is added to the end day.
Unsure of what noun to use for "sleep" in the dashboard since "nap" has an already established meaning and this counts all sleep sessions, not just naps. Went for the simple noun "sleep"
Relies on #484 .