Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure and explain debugging in devenv #711

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

barakplasma
Copy link
Contributor

@barakplasma barakplasma commented Sep 30, 2023

while testing PR 710 I wanted to debug it so I setup debugging support

@coveralls
Copy link

coveralls commented Sep 30, 2023

Coverage Status

coverage: 98.958% (-0.02%) from 98.976% when pulling 7b5eec2 on barakplasma:debug-in-devenv into 1ebe5a5 on babybuddy:master.

.vscode/launch.json Outdated Show resolved Hide resolved
devenv.nix Show resolved Hide resolved
Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you! I come primarily from a PHP development background and was never really able to sort out breakpoint debugging in Python. This makes it so easy.

Two additional ones (one directly related, one not so much):

Directly related:

When I follow the debugger documentation steps in Codespaces all the static files respond 404 so I don't get any CSS or JS in the app. I assume this is probably somehow related to the STATICFILES_STORAGE setting but wonder if you can reproduce/have any thoughts before I look closer at it.

Not so related:

Whenever I open the code in Codespaces I get this notification while things are still starting up. Is this expected and/or is there anything we can do to prevent it? It's just a bit confusing.

Screenshot from 2023-09-30 06-41-37

.vscode/launch.json Outdated Show resolved Hide resolved
devenv.nix Show resolved Hide resolved
docs/contributing/development-environment.md Outdated Show resolved Hide resolved
@barakplasma
Copy link
Contributor Author

Whenever I open the code in Codespaces I get this notification while things are still starting up. Is this expected and/or is there anything we can do to prevent it? It's just a bit confusing.

There's a newline added/removed occassionally from the devcontainer.json file when devenv shell runs that's causing this notification to happen in my experience. I am not sure what is causing it, or what the default should be, but I'm pretty sure that's the issue.

@cdubz
Copy link
Member

cdubz commented Sep 30, 2023

When I follow the debugger documentation steps in Codespaces all the static files respond 404 so I don't get any CSS or JS in the app. I assume this is probably somehow related to the STATICFILES_STORAGE setting but wonder if you can reproduce/have any thoughts before I look closer at it.

Any thoughts on this piece? And do you get the same issue?

@barakplasma
Copy link
Contributor Author

barakplasma commented Oct 4, 2023

When I follow the debugger documentation steps in Codespaces all the static files respond 404 so I don't get any CSS or JS in the app. I assume this is probably somehow related to the STATICFILES_STORAGE setting but wonder if you can reproduce/have any thoughts before I look closer at it.

Any thoughts on this piece? And do you get the same issue?

That happened to me because of the debug=true environment variable I had previously. I changed it to debug=false and now it doesn't happen

Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cdubz cdubz added this to the 2.1.0 milestone Oct 8, 2023
@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label Oct 8, 2023
@cdubz cdubz merged commit 7af0a65 into babybuddy:master Oct 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants