Fix misc report breadcrumb issues #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldReport pointing to the wrong report view. Fixed child sw itcher for WHO weight percentiles boy/girl reports.
|
Thanks for catching and fixing these issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed report breadcrumbs being duplicated.
The breadcrumbs throughout the report pages was duplicating the "Child Name / Reports" portion. This would happen regardless of whether you had one or more than one children saved.
Before
After
The breadcrumbs were also being duplicated on most reports which has also been fixed.
Before
After
Fixed DiaperChangeTypesChildReport pointing to the wrong report view.
When going to the Diaper Change Types report it would instead go to the Diaper Change Intervals report.
Before
After
Fixed child switcher for WHO weight percentiles boy/girl reports.
The "WHO Weight Percentiles for Boys/Girls in kg" reports would incorrectly redirect to the regular "Weight" report when switching between children via the quick switch dropdown in the breadcrumbs. I changed the WHO girl/boy reports to be a bit more independent of the regular weight report which enabled me to pass the independent urls to the child quick switch dropdown.