New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Height percentiles report (#719) #741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Happy to hear it was easy to get going.
I have just one small CR for a variable naming.
Also could you modify:
self.height = round(uniform(8.0, 12.0), 2) |
self.height = round(uniform(45.0, 60.0), 2)
?
As requested by @cdubz on babybuddy#741
As requested by @cdubz in babybuddy#741
Thanks for the review, that was a lot of copypasta mistakes on my part... I have applied the requested changes, fixed an additional bug in my last commit. |
Should I rebase this against master and update translation files to fix the conflict with |
Oh shoot yeah I forgot this PR also had locale changes. Yes you’ll need to merge in or rebase on |
ef18571
to
ea495b0
Compare
As requested by @cdubz in babybuddy#741
Rebased on master, re-ran |
ea495b0
to
8f091a7
Compare
One more rebase to fix formatting |
Looks good. Thanks for contributing! 🎅 |
Hi,
I really like the new WHO weight percentile report... So, here is my contribution proposal: a similar height percentile report (#719).
The implementation is really similar to that of the weight percentile report, it works in a dev environment. The instructions are great, writing this was pleasant! Kudos to the maintainers.
makemessages
has generated fuzzy entries for french, I took the liberty of also fixing the few instances unrelated to this change for french.Thanks for considering it for merging. Feel free to modify it in any way you see fit.