Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Postgres SSL #745

Merged
merged 7 commits into from Jan 6, 2024
Merged

Allow Postgres SSL #745

merged 7 commits into from Jan 6, 2024

Conversation

mmomjian
Copy link
Contributor

@mmomjian mmomjian commented Jan 5, 2024

Fixes #744

Has not been tested locally as I am unsure how to deploy the source.

@mmomjian
Copy link
Contributor Author

mmomjian commented Jan 5, 2024

If this is added, we could use docker with the environment var DB_OPTIONS: "{'sslmode': 'require'}". We could be more specific with creating a flag to specifically enable this variable, but adding an envvar for OPTIONS would seem to be more future-proof.

@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

coverage: 98.773% (-0.02%) from 98.791%
when pulling 969dec0 on mmomjian:master
into bdeb149 on babybuddy:master.

Copy link
Member

@cdubz cdubz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Can you update your PR to also add a note about this to the database configuration section?

@mmomjian
Copy link
Contributor Author

mmomjian commented Jan 5, 2024

I have added a section in the documentation, thanks.

@mmomjian mmomjian requested a review from cdubz January 5, 2024 23:33
Docs specified that postgres was the default variable, but settings/base.py:100-115 uses SQLite as default.
@mmomjian
Copy link
Contributor Author

mmomjian commented Jan 5, 2024

I also noticed that the documentation states that the default DB_ENGINE is django.db.backends.postgresql, but base.py seems to default to sqlite: "ENGINE": os.getenv("DB_ENGINE") or "django.db.backends.sqlite3". I made updates to the documentation to reflect this.

@cdubz cdubz merged commit 9b603a9 into babybuddy:master Jan 6, 2024
17 checks passed
@cdubz cdubz added enhancement Feature requests or improvements to existing functionality documentation Issues relating to documentation labels Jan 6, 2024
@cdubz cdubz added this to the 2.2.0 milestone Jan 6, 2024
@cdubz
Copy link
Member

cdubz commented Jan 6, 2024

Merged -- thanks for contributing!

@cdubz cdubz removed their request for review January 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to documentation enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Postgres SSL connections
3 participants