New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feeding method history #774
Conversation
Hi, are you able to add screenshots? |
Here you go. This is a standard one for breast feeding: But it works for any method. In case there are a lot for a day, it's only gonna display the top 3 methods in the "progress bar": For us, it mostly serves two purposes:
Maybe we could have this for the feeding type as well, and ideally allow the user to configure which one they want to display in the dashboard, but that's probably out of scope for that PR? I'd be open to giving it a try, if my baby gives me enough time :D |
#34 is the oldest open issue in this repo (: Definitely out of scope for this PR but I would be more than happy to have a PR adding that feature, hah. I have got a little steam behind it on a couple of occasions but never quite got it over the finish line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway looking at the actual change here --
I think the presentation of this can get confusing in practice. Here's an example with more of the various feeding types Baby Buddy supports:
I think you have a good use case here (quick understanding of the per-breast distribution) but I see two big issues here:
- For that use case none of the non-breast feeding types really matter.
- The colors are not always matched to the type which makes looking at this information quickly hard/confusing.
What do you think about renaming this specifically as "Breast Feedings", filtering for only left/right/both breast feeding methods, and maybe even redistributing "both breast" entries equals between the two groups to always reflect just two types?
Otherwise I think the presentation and code here is good.
- don't print days for an empty card. - make the width of the bar for each day proportional to that day's total feeding time.
Looks good. Thanks for contributing! |
Hi there,
First, thanks a lot for that project, it's very cool !
My partner is breastfeeding and wanted to have stats of how long she fed over the past days, and also which breast she used.
So I added a card similar to the diaper change history, but for feeding methods.
Let me know how it looks.