Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add diaper change color and amount fields #800

Merged
merged 2 commits into from Apr 15, 2024

Conversation

cdubz
Copy link
Member

@cdubz cdubz commented Apr 15, 2024

Fixes #799

@cdubz cdubz added the bug Reports of unexpected problems or errors label Apr 15, 2024
@cdubz cdubz added this to the 2.3.1 milestone Apr 15, 2024
@cdubz cdubz merged commit fcc6a79 into master Apr 15, 2024
11 checks passed
@cdubz cdubz deleted the 799-diaper-change-fields-missing branch April 15, 2024 13:38
@coveralls
Copy link

Coverage Status

coverage: 98.636% (-0.04%) from 98.671%
when pulling 407ca26 on 799-diaper-change-fields-missing
into eb88d65 on master.

@th0mcat
Copy link

th0mcat commented Apr 15, 2024

I think this broke the new Add Bottle Feeding option. Besides the two Amount fields, whenever I try to add a feeding in the past, it gives me the “ Another entry intersects the specified time period. ” error.

image

image

@cdubz
Copy link
Member Author

cdubz commented Apr 15, 2024

@th0mcat hmmm do you mean that the issue started with v2.3.1? Or did you experience it in v2.3.0 as well (if you used it)? This change shouldn't have impacted that check at all but it's possible something in the broader set of v2.3.0 did. Either way could you open a new issue for this?

@th0mcat
Copy link

th0mcat commented Apr 15, 2024

@cdubz can do!

MisterPhilip added a commit to MisterPhilip/babybuddy that referenced this pull request Apr 17, 2024
cdubz pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reports of unexpected problems or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diaper change color removed with 2.3.0
3 participants