-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: add performance and application metrics for BTC staking #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, these will be super handy!
Out of curiosity, how did you choose from which entity to emit the metrics? Afaik, Prom metrics are exposed both from the Telemetry module and a dedicated Prom server (by default listens to 26660
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very useful! Some questions about performance and types.
Also, let's change the base branch or wait until the new release before merging.
I think all metrics specified using the |
Let's wait until the new release then. This PR will be affected by the new finality provider set rotation logic as well. |
Thanks for the comments! This PR is now rebased to the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Fixes BM-1169
This PR introduces metrics for BTC staking. The metrics include both performance oriented ones and application specific ones. In particular, it includes
The implementation uses Cosmos SDK's native
telemetry
module.