Do not return errors for duplicated signatures #449
Conversation
| @@ -205,7 +205,7 @@ func (d *BTCDelegation) AddCovenantSigs(covPk *bbn.BIP340PubKey, sigs []asig.Ada | |||
| } | |||
| // ensure that this covenant member has not signed the delegation yet | |||
| if d.IsSignedByCovMember(covPk) { | |||
| return ErrDuplicatedCovenantSig | |||
There was a problem hiding this comment.
Maybe we can add log here for now and we can add metrics for motoring in the future
There was a problem hiding this comment.
Yea this is a bit which requires refactor. Currently this is a functin which is defined on BTCDelegation which does not have access to logger (and it should not have it)
In general this whole bit require moving those:
if d.HasCovenantQuorums(quorum) {
return nil
}
// ensure that this covenant member has not signed the delegation yet
if d.IsSignedByCovMember(covPk) {
return nil
}
those checks up the stack to Keeper or Msg_server , and addint proper logging there.
I would do it in next pr, so finality provider can update with this breaking change quickly. Next pr will be not breaking (it will be just some code golf)
There was a problem hiding this comment.
Ah makes sense. Thanks for the explaining!
| @@ -79,7 +79,7 @@ func (ud *BTCUndelegation) AddCovenantSigs( | |||
| } | |||
|
|
|||
| if ud.IsSignedByCovMember(covPk) { | |||
| return ErrDuplicatedCovenantSig | |||
There was a problem hiding this comment.
Maybe we can add log here for now and we can add metrics for motoring in the future
x/btcstaking/types/btc_delegation.go
Outdated
| @@ -205,7 +205,7 @@ func (d *BTCDelegation) AddCovenantSigs(covPk *bbn.BIP340PubKey, sigs []asig.Ada | |||
| } | |||
| // ensure that this covenant member has not signed the delegation yet | |||
There was a problem hiding this comment.
This comment can be cut or rephrased
KonradStaniec
deleted the
do-not-return-errors-for-duplicated-signatures
branch
Note:
It also adds todo to refactor adding covenant signatures to delegation as it is not optimal. This can be done in separate pr to not block update on finality provider.