Add check that validator exists before allowing for staking #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
approved these changes
Aug 7, 2023
babylonclient/babyloncontroller.go
Outdated
| btcPk, err := response.BtcValidator.BtcPk.ToBTCPK() | ||
|
|
||
| if err != nil { | ||
| return nil, fmt.Errorf("received malfored btc pk in babylon response: %w", err) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("received malfored btc pk in babylon response: %w", err) | |
| return nil, fmt.Errorf("received malformed btc pk in babylon response: %w", err) |
itest/e2e_test.go
Outdated
|
|
||
| resp, err = tm.BabylonClient.QueryValidators(100, 0) | ||
| require.NoError(t, err) | ||
| // No validators yet |
There was a problem hiding this comment.
Suggested change
| // No validators yet | |
| // Should be 1 validator |
| pop, | ||
| ) | ||
|
|
||
| resp, err = tm.BabylonClient.QueryValidators(100, 0) |
There was a problem hiding this comment.
Maybe we can also test QueryValidator here as this is the scope of this PR
staker/stakerapp.go
Outdated
Comment on lines
786
to
791
| _, err := app.babylonClient.QueryValidator(validatorPk) | ||
|
|
||
| if err != nil { | ||
| return nil, fmt.Errorf("error querying validator to stake funds to: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe it would be clearer if we wrap this into a method like func (app *StakerApp) validatorExists(valPk *btcec.PublicKey) (bool, error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20