Adapt spend stake endpoint to unbonding tx #48
Conversation
staker/stakerapp.go
Outdated
| foundingOutput *wire.TxOut | ||
| foundingOutputScript []byte |
There was a problem hiding this comment.
| foundingOutput *wire.TxOut | |
| foundingOutputScript []byte | |
| fundingOutput *wire.TxOut | |
| fundingOutputScript []byte |
| @@ -197,7 +204,7 @@ const ( | |||
|
|
|||
| // after this many confirmations we consider transaction which spends staking tx as | |||
| // confirmed on btc | |||
| stakingTxSpendTxConfirmation = 3 | |||
| SpendStakeTxConfirmations = 3 | |||
There was a problem hiding this comment.
Still think that those should come from Babylon, see my comment here
There was a problem hiding this comment.
My main qualm about tying it to babylon is that not always what is good for solo staker, is good for the chain as chain may require larger security margins i.e it is not entirely impossible that in some time we will say that k should be 20 to avoid thinking about any re-org possiblities or maybe we will delete k and leave only w . The those values will definitely be too large for any solo staker preferences.
I agree that current way is a bit haphazard, and using different values everywhere is a no-go for the future. My current thinking goes to introducing SafetyConfirmation parameter in config, which will have some minimum value like 2, and using it everywhere where does value does not depend on babylon safety. wdyt ?
There was a problem hiding this comment.
for now created issue for that we can discuss it further there - #49
There was a problem hiding this comment.
Hm ok, np with that. We should be clear that this is different than Babylon's parameter though and on some occassions the Babylon parameter is gonna be used.
staker/stakerapp.go
Outdated
| foundingTx *wire.MsgTx, | ||
| foundingTxHash *chainhash.Hash, | ||
| foundingTxStakingScript []byte, | ||
| foundingTxStakingOutputIdx uint32, |
There was a problem hiding this comment.
| foundingTx *wire.MsgTx, | |
| foundingTxHash *chainhash.Hash, | |
| foundingTxStakingScript []byte, | |
| foundingTxStakingOutputIdx uint32, | |
| fundingTx *wire.MsgTx, | |
| fundingTxHash *chainhash.Hash, | |
| fundingTxStakingScript []byte, | |
| fundingTxStakingOutputIdx uint32, |
stakerdb/trackedtranactionstore.go
Outdated
| // - transaction is in state SENT_TO_BABYLON, i.e staker created valid delegation and sent it to babylon | ||
| // - transaction is in state UNBONDING_CONFIRMED_ON_BTC, i.e staker already sent unbonding tx to btc network and | ||
| // it is confirmed | ||
| func (s *StoredTransaction) IsSpendableOnBtc() bool { |
There was a problem hiding this comment.
ahh leftover I will delete it.
|
marked pr as breaking due to api endpoint name change |
Changes:
spend_staking_txtospend_stakespend_stakeendpoint handle the case when stake was unbonded i.e it is currently in unbonding output.