-
Notifications
You must be signed in to change notification settings - Fork 189
Rename how_to to How To #634
Comments
note that this might require reindexing the how-to tutorials, please let me know when it is done. |
Hi @deltakosh , Where is it ? |
The search results have how_to in their title (for example - http://doc.babylonjs.com/search?q=highlight ) That's the first place I could find it in. |
Exactly. It is in every page from the how to (in the header) |
Having tried to use a space instead of _ in How_To and having got into all sorts of issues with internet URLS I ended up with doing a replace in the static.pug and statics.pug files for h1=staticContent.category.replace("_", " ") and h1=dataObj.category.replace("_"," ") respectively. This seems to me to be the easiest way to do it in the search results as well and so suggest the following changes in search.js on lines 73 and 83. I will not do a push for this in case this is not the way you want to go. Not sure if there are other places the how to hyphen appears but assume a similar solution would work.
|
Ping @Temechon and @QuentinRillet |
Woops a few days ago I tested out my idea for replacing _ in How_To with a local build and it worked. In my last commit these changes in search.js were still in place so got committed and pushed. Honestly I am not trying to take over the documentation (or perhaps it is just my first step to world domination :) ) |
Which commit was it? |
ced79cc but please note that though the change was not supposed to have been left in it does appear to solve the hyphen problem. Leave it to you as to what you want to do. |
This is perfect :) |
Should I reindex the how-tos? |
Nope that's the magic of it |
They are still shown as How_To in the search index - http://doc.babylonjs.com/search?q=highlight (even after reindexing) |
Ah ! Right. We need to do the little replace trick here as well:) |
And then I'll have to reindex ;) |
Sure you like it |
Can we reindex? ping @QuentinRillet |
I don't see any underscores in the search result... It seems it has already been done: BabylonJS/Documentation@ced79cc#diff-7150cea0f9818367b6d63c04bcfead00 |
Good :) |
No description provided.
The text was updated successfully, but these errors were encountered: