Skip to content

Commit

Permalink
fix: RetriesSuite uses a valid config
Browse files Browse the repository at this point in the history
- Ensures a request config is produced for testing that will not cause
  panics and has a default node membership state of 'Approved'.

- ffs same bug as previous commit, wonder how many more instances of
  this there are. *sobs into keyboard*
  • Loading branch information
frrist authored and frrist committed May 6, 2024
1 parent 2e43a8e commit aace34c
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions pkg/test/requester/retries_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,10 @@ func (s *RetriesSuite) SetupSuite() {
}
ctx := context.Background()

requesterConfig, err := node.NewRequesterConfigWith(
node.RequesterConfigParams{
NodeRankRandomnessRange: 0,
OverAskForBidsFactor: 1,
},
)
requesterConfig, err := node.NewRequesterConfigWithDefaults()
s.Require().NoError(err)
requesterConfig.OverAskForBidsFactor = 1

stack := teststack.Setup(ctx, s.T(),
devstack.WithNumberOfRequesterOnlyNodes(1),
devstack.WithNumberOfComputeOnlyNodes(len(nodeOverrides)-1),
Expand Down

0 comments on commit aace34c

Please sign in to comment.