Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out streaming client into consumer and producer client and add heart beat logic #4025

Closed
Tracked by #4003
udsamani opened this issue May 22, 2024 · 0 comments · Fixed by #4027
Closed
Tracked by #4003
Assignees

Comments

@udsamani
Copy link
Collaborator

udsamani commented May 22, 2024

What is this change about ?

Currently our NATS streaming client does multiple things. On requester node side. it is used as a consumer of log messages coming via NATS and on compute node it acts as write, where it reads logs from appropriate execution engines and puts them as messages on NATS subject.

With this change we go with single responsibility per client and split the client into ConsumerClient and ProducerClient. This makes it easy and each client has single responsibility.

With this change we also add the logic of producer client sending heart beats to consumer client on a heart beat request subject, when a connection is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant