Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print ranking failures in the CLI #3752

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Print ranking failures in the CLI #3752

merged 1 commit into from
Apr 3, 2024

Conversation

simonwo
Copy link
Contributor

@simonwo simonwo commented Apr 3, 2024

Currently, ranking failures are once again not visible in the CLI:

% bin/darwin/arm64/bacalhau --api-host=localhost job run testdata/jobs/docker.yaml
Job successfully submitted. Job ID: j-954d00df-c59f-4c65-8663-da8f112ec9cb
Checking job status... (Enter Ctrl+C to exit at any time, your job will continue running):

	Communicating with the network  ................  done ✅  2.7s
	   Creating job for submission  ................  err  ❌  01m00.8s

Error submitting job: 
Job Results By Node:

To get more details about the run, execute:
	bacalhau job describe j-954d00df-c59f-4c65-8663-da8f112ec9cb

To get more details about the run executions, execute:
	bacalhau job executions j-954d00df-c59f-4c65-8663-da8f112ec9cb

The "Error submitting job" and "Job Results By Node" lines should be displaying a ranking failure.

A bug in the BoltDB job store implementation meant that any non-execution comments were not stored. This commit stores the error from the scheduler in the job state as it used to be so that it can be printed on the CLI.

It also only prints "Job Results by Node" if the job was actually successfully placed on any node, and adds a test.

@simonwo simonwo added the type/bug Type: Something is not working as expected label Apr 3, 2024
@simonwo simonwo requested a review from a team April 3, 2024 06:55
@simonwo simonwo self-assigned this Apr 3, 2024
Copy link

coderabbitai bot commented Apr 3, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

A bug in the BoltDB job store implementation meant that any
non-execution comments were not stored. This commit stores the error
from the scheduler in the job state as it used to be so that it can be
printed on the CLI.

It also only prints "Job Results by Node" if the job was actually
successfully placed on any node, and adds a test.
Copy link
Contributor

@rossjones rossjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, helped identify another bug in #3754 too

@simonwo simonwo merged commit c823e23 into main Apr 3, 2024
12 checks passed
@simonwo simonwo deleted the simonwo/error-msgs branch April 3, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Type: Something is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants