Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ranking error output #3763

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Improve ranking error output #3763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions pkg/orchestrator/errors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ package orchestrator

import (
"fmt"
"strings"

"github.com/bacalhau-project/bacalhau/pkg/util/idgen"
"github.com/samber/lo"
)

// ErrSchedulerNotFound is returned when the scheduler is not found for a given evaluation type
Expand Down Expand Up @@ -33,16 +35,22 @@ func NewErrNotEnoughNodes(requestedNodes int, availableNodes []NodeRank) ErrNotE
}

func (e ErrNotEnoughNodes) Error() string {
nodeErrors := ""
available := 0
for _, rank := range e.AvailableNodes {
if rank.MeetsRequirement() {
available += 1
suitable := lo.CountBy(e.AvailableNodes, func(rank NodeRank) bool { return rank.MeetsRequirement() })
reasons := lo.GroupBy(e.AvailableNodes, func(rank NodeRank) string { return rank.Reason })

var message strings.Builder
fmt.Fprint(&message, "not enough nodes to run job. ")
fmt.Fprintf(&message, "requested: %d, available: %d, suitable: %d.", e.RequestedNodes, len(e.AvailableNodes), suitable)
for reason, nodes := range reasons {
fmt.Fprint(&message, "\n• ")
if len(nodes) > 1 {
fmt.Fprintf(&message, "%d of %d nodes", len(nodes), len(e.AvailableNodes))
} else {
nodeErrors += fmt.Sprintf("\n\tNode %s: %s", idgen.ShortNodeID(rank.NodeInfo.ID()), rank.Reason)
fmt.Fprintf(&message, "Node %s", idgen.ShortNodeID(nodes[0].NodeInfo.ID()))
}
fmt.Fprintf(&message, ": %s", reason)
}
return fmt.Sprintf("not enough nodes to run job. requested: %d, available: %d. %s", e.RequestedNodes, available, nodeErrors)
return message.String()
}

// ErrNoMatchingNodes is returned when no matching nodes in the network to run a job
Expand Down
Loading