-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RunE instead of Run for cobra commands #3767
Conversation
We were inconsistently using Run/RunE in various places, and this PR fixes that to ensure that all commands use RunE and rely on the call to util.Fatal in the root of the command. Resolves #3764
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
We were inconsistently using Run/RunE in various places, and this PR fixes that to ensure that all commands use RunE and rely on the call to util.Fatal in the root of the command. Resolves #3764
We were inconsistently using Run/RunE in various places, and this PR fixes that to ensure that all commands use RunE and rely on the call to util.Fatal in the root of the command.
Resolves #3764