-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set minimum client version on http server #4117
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
pkg/publicapi/middleware/version.go
Outdated
return c.JSON(http.StatusForbidden, map[string]string{ | ||
"Error": "Client version is outdated. Update your client", | ||
"ServerVersion": serverVersion.String(), | ||
"MinimumVersion": minVersion.String(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently this will return the minimum version is https://github.com/bacalhau-project/bacalhau/pull/4117/files#diff-19907c38cadb733516c5d0d2d452e8ef1dde593253b301251fec43f1a8a8d315R30 (1.3.3) which isn't actually a version. Should we bump the min version to 1.4.0?
Some changes in the upcoming release are not compatible with existing clients, such as #4115
This PR prints a human readable message asking users to update their client