Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: demo broken, related to h5py? #86

Closed
kdesimone opened this issue Dec 16, 2016 · 1 comment
Closed

JOSS review: demo broken, related to h5py? #86

kdesimone opened this issue Dec 16, 2016 · 1 comment

Comments

@kdesimone
Copy link

kdesimone commented Dec 16, 2016

I think the demo assumes that you cd into pyret/docs in order load the tutorial-data.h5 dataset. What happens if you install via pip and not from source?

Also, once I've navigated to pyret/docs, I get this error:

AttributeError Traceback (most recent call last)
<ipython-input-6-ec7d48997ae9> in <module>()
7 spikes = data_file['spike-times'] # Spike times for one cell
8 stimulus = data_file['stimulus']
----> 9 stimulus -= stimulus.mean()
10 stimulus /= stimulus.std()
11 time = np.arange(stimulus.shape[0]) * data_file['stimulus'].attrs.get('frame-rate')

AttributeError: 'Dataset' object has no attribute 'mean'

I installed h5py, version 2.6.0.

@bnaecker
Copy link
Contributor

bnaecker commented Dec 19, 2016

The demo does assume the working directory is pyret/docs. I've made that clearer in a new commit that will be merged into master soon. This also fixes the AttributeError you point out above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants