Cleanup GUI #706
Cleanup GUI #706
Conversation
dominikbach
added
Completed & Waiting for Review
teddychao
added
Under Review
and removed
Completed & Waiting for Review
| @@ -1,4 +1,4 @@ | |||
| function artefact_rm = pspm_cfg_artefact_rm | |||
There was a problem hiding this comment.
This is fine currently. As I understand, version 7.0 will no longer include the section "Tools", so currently there is no problem. Yet if it is in 6.x versions, the pspm_guide and pspm_appdesigner, which include the module tools, will need to be updated for making them in line with these files.
| tau.num = [1 1]; | ||
| tau.help = {'Time constant in seconds.'}; | ||
|
|
||
| FilterLeaky = cfg_branch; |
There was a problem hiding this comment.
I apologise if I wrote these in capitalised format like this. I have changed to use smaller case since last discussion.
| %% Manual mode | ||
| mode_manual = cfg_branch; | ||
| mode_manual.name = 'Manual'; | ||
| mode_manual.tag = 'mode_manual'; | ||
| mode_manual.val = {datafile, channel, conditions}; | ||
| mode_manual.val = {channel, timeunits, session_rep}; |
There was a problem hiding this comment.
Just to mention, in the new version there is no "data files" item. Instead, there is a "Data & Design". This is quite "session_rep" rather than "data file". If this is expected, please ignore me.
Extract segments
Before:
After:
There was a problem hiding this comment.
Yes, this is intended.
|
Tested these functions in the GUI and found them working ok, just a minor comment listed above. |
teddychao
added
Completed & Waiting for Review
teddychao
removed
the
Completed & Waiting for Review
Fixes #591 .
Fixes #599 .
Fixes #669 .
Fixes #671 .
Fixes #687 .
Fixes #688 .
Fixes #715 .
Changes proposed in this pull request: