Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classmethod from async_check_api_key #19

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Remove classmethod from async_check_api_key #19

merged 1 commit into from
Nov 9, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Nov 9, 2022

Describe what the PR does:

After starting the HASS integration, I realized the @classmethod version of async_check_api_key isn't terribly useful. This PR moves it to a standard method on an instantiated API object.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added maintenance Generic library tasks breaking-change A breaking change for existing users labels Nov 9, 2022
@bachya bachya self-assigned this Nov 9, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 9, 2022

Code Climate has analyzed commit dcb593c and detected 0 issues on this pull request.

View more on Code Climate.

@bachya bachya merged commit 394ce60 into dev Nov 9, 2022
@bachya bachya deleted the check branch November 9, 2022 03:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users maintenance Generic library tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant