Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter response payload for API.sensors.async_get_nearby_sensors #28

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Dec 2, 2022

Describe what the PR does:

During the implementation of the Home Assistant integration, I found a situation where it'd be useful for the results of API.sensors.async_get_nearby_sensors to return the SensorModel objects and the calculated distance for each.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the breaking-change A breaking change for existing users label Dec 2, 2022
@bachya bachya self-assigned this Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #28 (d3a4e72) into dev (4fe5f08) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          480       486    +6     
=========================================
+ Hits           480       486    +6     
Impacted Files Coverage Δ
aiopurpleair/endpoints/sensors.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit fa9bd0f into dev Dec 2, 2022
@bachya bachya deleted the nearby-update branch December 2, 2022 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change A breaking change for existing users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant