Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure "reminder only" results are hidden #215

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Ensure "reminder only" results are hidden #215

merged 1 commit into from
Sep 6, 2023

Conversation

bachya
Copy link
Owner

@bachya bachya commented Sep 6, 2023

Describe what the PR does:

According to home-assistant/core#99480, some ReCollect calendars include "reminders" (non-pickup-related flags) that can clog up the results for some place/service ID combinations. This PR ensures that reminders are ignored in responses.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.

@bachya bachya added the bug Bugs or issues which will cause a problem for users label Sep 6, 2023
@bachya bachya self-assigned this Sep 6, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 6, 2023

Code Climate has analyzed commit 0916b89 and detected 0 issues on this pull request.

View more on Code Climate.

@bachya bachya merged commit b5114e1 into dev Sep 6, 2023
8 checks passed
@bachya bachya deleted the hide-reminders branch September 6, 2023 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs or issues which will cause a problem for users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant