Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect retrieval of file_public_path #129

Closed
argiepiano opened this issue Dec 10, 2023 · 2 comments
Closed

Incorrect retrieval of file_public_path #129

argiepiano opened this issue Dec 10, 2023 · 2 comments

Comments

@argiepiano
Copy link
Collaborator

argiepiano commented Dec 10, 2023 •
edited
Loading

In D7, class backup_migrate_files_destination_archivesource gets the file_public_path by using variable_get(). When backup_migrate was ported, this was adapted by using config_get('backup_migrate.settings','file_public_path'), which, of course, is wrong. In BAckdrop the counterpart of the variable file_public_path is obtained by doing config_get('system.core', 'file_public_path'). This should be changed.
argiepiano added a commit to argiepiano/backup_migrate that referenced this issue Dec 10, 2023
@argiepiano
Issue backdrop-contrib#129. Get the correct file_public_path
956d08d
@argiepiano argiepiano mentioned this issue Dec 10, 2023
Closed
@argiepiano
Copy link
Collaborator Author

PR #130

@argiepiano
Copy link
Collaborator Author

Will close this since this was addressed more comprehensively in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #129. Get the correct file_public_path argiepiano/backup_migrate
1 participant
@argiepiano