Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #125. Remove non-sensible directory defaults for config active and staging. #142

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

argiepiano
Copy link
Collaborator

Fixes #125

@indigoxela
Copy link
Member

Hm... if I run tests locally, they fail, too. Not exactly the same failures. On php 8.2 - which might be a little too new. Currently test in GHA run on 7.4.

@argiepiano
Copy link
Collaborator Author

Thanks @indigoxela. I'll check tests in 8.2.

BTW these tests on GHA have been failing randomly - when I run them again they pass usually. The error this one shows is completely puzziling: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'backdrop.simpletest331674cache_entity_comment' doesn't exist: SHOW CREATE TABLE simpletest331674cache_entity_comment;

@argiepiano
Copy link
Collaborator Author

I just ran all 3 backup_migrate tests locally on 8.2 based on the dev version and with this patch, and they are all passing for me. Perhaps you are using an older dev version? If you have the time to run those again locally at some point and find issues again, pls let me know.

I'm going to close and reopen this to run the GHA tests again.

@argiepiano argiepiano closed this Dec 16, 2023
@argiepiano argiepiano reopened this Dec 16, 2023
@argiepiano
Copy link
Collaborator Author

Tests pass on reopening 🙄

@argiepiano argiepiano merged commit f6f5cbe into backdrop-contrib:1.x-1.x Dec 16, 2023
1 of 2 checks passed
@indigoxela
Copy link
Member

Tests pass on reopening

That's good. And bad. But currently good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values make no sense for config directories
2 participants