Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Drupal. in js file #31

Closed
laryn opened this issue Feb 2, 2022 · 4 comments · Fixed by #33
Closed

Clean up Drupal. in js file #31

laryn opened this issue Feb 2, 2022 · 4 comments · Fixed by #33

Comments

@laryn
Copy link
Member

laryn commented Feb 2, 2022

It looks like a recent merge of updates from the Drupal side leaked in some Drupal.'s in the js file.
@laryn
Copy link
Member Author

laryn commented Feb 2, 2022

Also a few drupal_'s in the api file.

@laryn
Copy link
Member Author

laryn commented Feb 2, 2022

I can submit a PR unless it's easier for you to do it since you seem to be at work at this moment...

laryn added a commit to laryn/colorbox that referenced this issue Feb 3, 2022
@laryn
Issue backdrop-contrib#31: Clean up Drupal references.
0f46175 
Fixes backdrop-contrib#31.
@laryn laryn mentioned this issue Feb 3, 2022
Merged
@laryn
Copy link
Member Author

laryn commented Feb 3, 2022

@jenlampton ☝️

jenlampton added a commit that referenced this issue Feb 3, 2022
@jenlampton
Merge pull request #33 from laryn/1.x-2.x
129959a 
Issue #31: Clean up Drupal references.
@jenlampton
Copy link
Member

Thanks @laryn, I meant to do a check for Drupals before I released. Obviously I forgot! PR merged.

jenlampton pushed a commit that referenced this issue Apr 11, 2022
@laryn
Issue #31: Clean up Drupal references.
4b46c57 
Fixes #31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #31: Clean up Drupal references. laryn/colorbox
2 participants
@jenlampton @laryn