Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module still includes a check for the token module. #6

Closed
Graham-72 opened this issue Jul 5, 2016 · 4 comments · Fixed by #34
Closed

Module still includes a check for the token module. #6

Graham-72 opened this issue Jul 5, 2016 · 4 comments · Fixed by #34

Comments

@Graham-72
Copy link
Member

Graham-72 commented Jul 5, 2016 •
edited by klonos
Loading

At colorbox.module line 390 there is a check that at line 409 produces a warning in Backdrop.
@klonos
Copy link
Member

klonos commented Jul 5, 2016

Token is now part of core and always enabled + hidden I think we can safely remove that check.

jenlampton pushed a commit to jenlampton/colorbox that referenced this issue May 22, 2017
Issue backdrop-contrib#6: Remove check for legacy token module.
406f5d3
@jenlampton jenlampton mentioned this issue May 22, 2017
Merged
jenlampton added a commit that referenced this issue May 22, 2017
@jenlampton
Merge pull request #14 from jenlampton/6-token
892ee32 
Issue #6: Remove check for legacy token module.
@laryn laryn reopened this Feb 3, 2022
@laryn
Copy link
Member

laryn commented Feb 3, 2022

There's a section related to this that can still be cut out:

https://github.com/backdrop-contrib/colorbox/blob/1.x-2.x/colorbox.module#L402-L413

laryn added a commit to laryn/colorbox that referenced this issue Feb 3, 2022
@laryn
Issue backdrop-contrib#6: Remove notice about installing token module.
5dbc40e 
Fixes backdrop-contrib#6.
laryn added a commit to laryn/colorbox that referenced this issue Feb 3, 2022
@laryn
Issue backdrop-contrib#6: Remove notice about installing token module.
6830b90 
Fixes backdrop-contrib#6.
laryn added a commit to laryn/colorbox that referenced this issue Feb 3, 2022
@laryn
Issue backdrop-contrib#6: Remove notice about installing token module.
8c4e7b4 
Fixes backdrop-contrib#6.
@laryn laryn mentioned this issue Feb 3, 2022
Merged
@laryn
Copy link
Member

laryn commented Feb 3, 2022

Sorry, I had some unrelated changes that kept getting included in there but have a clean PR on this one now.

jenlampton added a commit that referenced this issue Feb 3, 2022
@jenlampton
Merge pull request #34 from laryn/1.x-2.x-issue-6
462ec27 
Issue #6: Remove notice about installing token module.
@jenlampton
Copy link
Member

Thanks @laryn, PR merged!

jenlampton pushed a commit that referenced this issue Apr 11, 2022
@laryn
Issue #6: Remove notice about installing token module.
5bf478b 
Fixes #6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #6: Remove notice about installing token module. laryn/colorbox
4 participants
@jenlampton @laryn @klonos @Graham-72