Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1: Deprecated function: Return type of FacetapiFacet::offsetExists($offset) should either be compatible with ArrayAccess #14

Closed
argiepiano opened this issue Mar 13, 2023 · 4 comments · Fixed by #18
Closed

PHP 8.1: Deprecated function: Return type of FacetapiFacet::offsetExists($offset) should either be compatible with ArrayAccess #14

argiepiano opened this issue Mar 13, 2023 · 4 comments · Fixed by #18

Comments

@argiepiano
Copy link
Contributor

When running this module on PHP 8.1, I'm getting:

Deprecated function: Return type of FacetapiFacet::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in require_once() (line 1131 of... Sites/localhost/panettone/modules/facetapi/plugins/adapter.inc).

This is similar to several other places in core and contrib where we've had to add #[\ReturnTypeWillChange] right above the offending methods.
@herbdool
Copy link
Contributor

@argiepiano feel like making a PR? I can test it and we can merge it later as part of Bug Squad.

argiepiano added a commit to argiepiano/facetapi that referenced this issue Aug 27, 2023
@argiepiano
Issue backdrop-contrib#14. Add #[\ReturnTypeWillChange] to methods th…
e8ffee0 
…at extend ArrayAccess

Fixes backdrop-contrib#14
@argiepiano argiepiano mentioned this issue Aug 27, 2023
Merged
@argiepiano
Copy link
Contributor Author

Done! PR #18

@herbdool
Copy link
Contributor

LGTM

@argiepiano argiepiano mentioned this issue Nov 29, 2023
Closed
@argiepiano
Copy link
Contributor Author

I'll merge this, since it was LGTM back in August.

argiepiano added a commit that referenced this issue Nov 29, 2023
@argiepiano
Merge pull request #18 from argiepiano/1.x-1.x-issue-14
0bd715d 
Issue #14. Add   #[\ReturnTypeWillChange] to methods that extend ArrayAccess
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #14. Add #[\ReturnTypeWillChange] to methods that extend ArrayAccess argiepiano/facetapi
2 participants
@herbdool @argiepiano