Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n_string localized term translation doesn't use CKEditor for description #66

Closed
laryn opened this issue Apr 15, 2021 · 6 comments
Closed

Comments

@laryn
Copy link
Member

laryn commented Apr 15, 2021

I noticed when translating localized terms that the description displays HTML code instead of using the CK Editor as expected. PR coming.

@indigoxela
Copy link
Member

@laryn many thanks for your PR, I'll look into this ASAP, but maybe not before weekend.

@laryn
Copy link
Member Author

laryn commented Apr 15, 2021

Hmm... it's actually not working completely. I hadn't actually tried saving the translation, which produces an SQL syntax error with this PR.

@indigoxela
Copy link
Member

@laryn should be fixed in 16c2a2e. Please test thoroughly, the automated tests are passing, but "human eyes" still might find something. 😃

@laryn
Copy link
Member Author

laryn commented Apr 19, 2021

Manually patched my dev site and did some testing -- basic functionality is looking good! A few visual/UI suggestions that come to mind as I am testing:

  • can the submit button be wrapped in a '#type' => 'actions' array? I think this gives the button more consistent styling with the rest of the UI
  • Adding the CKEditor interface also adds "Formatting options" so the manually added description is duplication:
    Screenshot_2021-04-19 Translate to Español
  • The CKEditor editing window opens very narrow, it should maybe be made taller by default:
    Screenshot_2021-04-19 Translate to Español_2

@indigoxela
Copy link
Member

...A few visual/UI suggestions that come to mind...

@laryn many thanks for testing. The visual glitches should be fixed in 11ff8c9.

@laryn
Copy link
Member Author

laryn commented Apr 20, 2021

Looks great!

@laryn laryn closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants