Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit buttons should be in 'actions' wrapper #68

Closed
laryn opened this issue Apr 20, 2021 · 2 comments · Fixed by #69
Closed

Submit buttons should be in 'actions' wrapper #68

laryn opened this issue Apr 20, 2021 · 2 comments · Fixed by #69

Comments

@laryn
Copy link
Member

laryn commented Apr 20, 2021

To take advantage of core button styling, can we wrap submit buttons in an actions container? I can make a PR.
laryn added a commit to laryn/i18n that referenced this issue Apr 20, 2021
@laryn
backdrop-contrib#68: Clean up form submit buttons
bb45362
@laryn laryn mentioned this issue Apr 20, 2021
Merged
@indigoxela
Copy link
Member

A recent core change broke i18n tests. A fix is available now, but would require rebasing.

Also, it seems to me that the PR contains unneeded changes, where the #type already is "actions".

indigoxela pushed a commit that referenced this issue Jan 19, 2022
@laryn
#68: Submit buttons should be in 'actions' wrapper (#69) by @laryn
01ab2e3
@indigoxela
Copy link
Member

I'm trying to get a little closer to a stable release, merged. @laryn many thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#68: Submit buttons should be in 'actions' wrapper laryn/i18n
2 participants
@indigoxela @laryn