Issue #37: Add ability to exclude certain files from the Packager #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quicksketch
reviewed
Aug 4, 2019
| $release_node->type = 'module_release'; | ||
| } | ||
| else { | ||
| $errors['project_type_invalid'] = t('Project releases are only supported on module projects.'); |
There was a problem hiding this comment.
Looks like in this example, the $errors variable would not be returned anywhere.
There was a problem hiding this comment.
Ooops, That was a copy/paste from the api example just above it. Pushed a more appropriate example
quicksketch
reviewed
Aug 4, 2019
| * @return NULL | ||
| * No return value. | ||
| */ | ||
| function hook_project_github_create_package_alter($project_name, array $files) { |
There was a problem hiding this comment.
Suggested change
| function hook_project_github_create_package_alter($project_name, array $files) { | |
| function hook_project_github_create_package_alter(array &$files, $project_name) { |
I think $files has to be passed by reference in order for this to work.
There was a problem hiding this comment.
Hm, and actually most alter hooks have the array that is altered as the first parameter. e.g. hook_form_alter() passes $form, $form_state, and $form_id. This is similar where the $form_id is passed last even though it is the identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37