Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange User notice error in logs #43

Open
jenlampton opened this issue Sep 7, 2017 · 5 comments · Fixed by #65

Comments

@jenlampton
Copy link
Member

commented Sep 7, 2017

In my log files I'm seeing the following PHP error

User notice:
array (
)
in xmlsitemap_node_xmlsitemap_index_links() (line 43 of backdrop/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module

noting here so I can diagnose later.

@alexfinnarn

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2018

Any luck diagnosing @jenlampton? The line numbers have changed, and I'm not sure what is going on.

@jenlampton

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2018

I haven't dug into it yet, but I'm seeing a different line number now too:

User notice: array ( ) in xmlsitemap_node_xmlsitemap_index_links() (line 56 of /backdrop/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module).
@alexfinnarn

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2018

I tracked this down to the debug($nids) statement in that function. The attached PR just checks to see if the database query has results and then does the processing if so.

This may have been a debugging statement that was never removed, but I'm not sure why a debug message needs to be logged every time the links are indexed.

It may be better to remove the debugging statement altogether, but it still makes sense to not call xmlsitemap_node_xmlsitemap_process_node_links() if there are no node IDs to check.

@alexfinnarn alexfinnarn modified the milestones: 1.0.4, 1.0.5 Aug 1, 2018

alexfinnarn added a commit that referenced this issue Aug 6, 2018
Merge pull request #65 from backdrop-contrib/bug/43
Issue #43: strange User notice error in logs
@jenlampton

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

I'm still seeing the error in my logs. reopening.

User notice:
array (
)
in xmlsitemap_node_xmlsitemap_index_links() (line 81 of backdrop/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module).

@jenlampton jenlampton reopened this May 29, 2019

@jenlampton

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Hm, the debug doesn't seem to be there in the latest 1.x. Maybe all we need is a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.