Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange User notice error in logs #43

Closed
jenlampton opened this issue Sep 7, 2017 · 6 comments · Fixed by #65
Closed

strange User notice error in logs #43

jenlampton opened this issue Sep 7, 2017 · 6 comments · Fixed by #65
Labels
Milestone

Comments

@jenlampton
Copy link
Member

In my log files I'm seeing the following PHP error

User notice:
array (
)
in xmlsitemap_node_xmlsitemap_index_links() (line 43 of backdrop/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module

noting here so I can diagnose later.

@alexfinnarn
Copy link
Contributor

Any luck diagnosing @jenlampton? The line numbers have changed, and I'm not sure what is going on.

@jenlampton
Copy link
Member Author

I haven't dug into it yet, but I'm seeing a different line number now too:

User notice: array ( ) in xmlsitemap_node_xmlsitemap_index_links() (line 56 of /backdrop/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module).

@alexfinnarn
Copy link
Contributor

I tracked this down to the debug($nids) statement in that function. The attached PR just checks to see if the database query has results and then does the processing if so.

This may have been a debugging statement that was never removed, but I'm not sure why a debug message needs to be logged every time the links are indexed.

It may be better to remove the debugging statement altogether, but it still makes sense to not call xmlsitemap_node_xmlsitemap_process_node_links() if there are no node IDs to check.

@alexfinnarn alexfinnarn modified the milestones: 1.0.4, 1.0.5 Aug 1, 2018
alexfinnarn pushed a commit that referenced this issue Aug 6, 2018
Issue #43: strange User notice error in logs
@jenlampton
Copy link
Member Author

I'm still seeing the error in my logs. reopening.

User notice:
array (
)
in xmlsitemap_node_xmlsitemap_index_links() (line 81 of backdrop/modules/contrib/xmlsitemap/xmlsitemap_node/xmlsitemap_node.module).

@jenlampton jenlampton reopened this May 29, 2019
@jenlampton
Copy link
Member Author

Hm, the debug doesn't seem to be there in the latest 1.x. Maybe all we need is a new release?

@laryn
Copy link
Member

laryn commented May 28, 2020

New release has been made since last comment. Reopen if still an issue.

@laryn laryn closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants