-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import the Sources #1
Comments
Here's a list of significant commit hashes giving a rough timeline:
So it looks like somewhere between Jan 13 and May 31, 2012 is where things started converting heavily to PSR-0. By May with the introduction of the Drupal Kernel, a large number of systems has already been converted: Language, Lock, Mail, Queue, StreamWrapper, Updater, Utility, Graph, Archiver, and others. So I think we'll need to back further than just the introduction of the Kernel itself. The first systems converted were Cache, CMI, and then DBTNG (in that order). A semi-working of CMI appears to have existed before it was converted to PSR-0 in Feb 2012, but then it was fully converted before the main version was pulled into core Mar 2, 2012. After March 8, a large number of systems are converted to PSR-0 in a short amount of time. My guess is that after that date, we won't be able to import changes wholesale, so some time in late Feb/early March looks like it's about the best time for starting the repository. |
Initially when I tried this, I used http://drupalcode.org/sandbox/damiankloip/1778654.git/commit/da3a59b, the last commit (March 8, 2012), before PSR-0 started converting in earnest. However that was after CMI, DBTNG, and the cache layers had already been converted. The reverting of DBTNG's PSR-0 version moved a large amount of files and was stretched over multiple commits. So instead of starting there, I went back another week to Feb 29, 2012, to the last commit before DBTNG's PSR-0 conversion d1aee00aaf7623616f791af8b64e14f39d74e372. The full log looks something like this:
Removing Symfony also had to be done manually, as the /core directory move made using git revert impossible (afaik). Fortunately because Symfony wasn't actually used for a long time (about a month) after it's initial commit, rolling back it's change individually isn't difficult at all (as can be seen in 740963a). To avoid versioning conflicts in the future, I've prepended "drupal-" to all the old version tags. As in the summary of commands above, I also restarted versioning back at a 1.x branch for this project. As an added bonus, merging in the Pre-PSR-0 version of CMI is a piece of cake with this earlier version. After the success of being able to install and run Backdrop normally, I've pushed up this initial commit to the repo! |
Initially fixed with backdrop/backdrop@740963a. |
It's worth noting that I then had to revert the CMI branch. That's now being tracked in #2 |
Passing Pantheon DB Settings to Backdrop
We need to find a suitable location in history from which to begin our repository. We definitely want pre-Drupal Kernel and the PSR-0 namespacing, but at the same time we'd like at least a reasonable start on CMI. It looks like from the history of the repository, there was quite a bit of overlap between CMI and at least PSR-0.
The text was updated successfully, but these errors were encountered: