Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Views UI: Modal dialogs: Indent form elements that are hidden/shown via #states #1968

Open
klonos opened this issue Jun 13, 2016 · 9 comments

Comments

@klonos
Copy link
Member

klonos commented Jun 13, 2016

Description and screenshots coming up...

This is related to #1828

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

So, here's the thing... take for example the title field dialog from a view:

backdrop-issue1968-style_settings_fieldset-options_unchecked

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

...once you check these options, you get this:

backdrop-issue1968-style_settings_fieldset-options_checked-one_level_of_settings

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

backdrop-issue1968-style_settings_fieldset-options_checked-one_level_of_settings-css_class_options_unchecked

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

...now, you get this:

backdrop-issue1968-style_settings_fieldset-options_checked-one_level_of_settings-css_class_options_checked

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

This is how it should be:

backdrop-issue1968-style_settings_fieldset-options_indented

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

I tried making a start of a PR, but realized that I cannot do much unless we get something like #1969 in place.

@klonos
Copy link
Member Author

klonos commented Jun 13, 2016

...by the way, the above screenshots were made having "hacked" my way through CSS max page height. Here's the really bad UX users get in reality with the modal being in the default 400px height with all these options checked and scrolling required to access/preview them:

backdrop-issue1968-scrolling

@klonos
Copy link
Member Author

klonos commented Feb 24, 2019

So here's what we currently have, compared to how things should ideally look (including #1828):

image

@klonos
Copy link
Member Author

klonos commented Feb 24, 2019

...what would also help in this specific fieldset would be to rename the "CSS class" labels.

HTML element -> Field HTML element
CSS class -> Field CSS class
CSS class -> Label CSS class
CSS class -> Wrapper CSS class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant