Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floated content inside of Rich Text areas breaks outside container #2295

Closed
wesruv opened this issue Oct 21, 2016 · 4 comments
Closed

Floated content inside of Rich Text areas breaks outside container #2295

wesruv opened this issue Oct 21, 2016 · 4 comments
Labels
status - fixed type - bug report
Milestone
1.10.1

Comments

@wesruv
Copy link
Member

wesruv commented Oct 21, 2016

Probably need a clearfix.
@wesruv
Copy link
Member Author

wesruv commented Oct 21, 2016

PR Here:
backdrop/backdrop#1625

@quicksketch quicksketch mentioned this issue Feb 19, 2018
Closed
@quicksketch
Copy link
Member

#2982 is a similar issue.

Looking at this fix vs. that one, I actually think both might be appropriate. While that other issue suggests adding clearfix to the entire node's content, this issue would fix the display of the body field pretty much everywhere it is used. Though to make this more comprehensive, I'd suggest that we do it both on text_with_summary and text_long fields. Right now this only covers text with summary.

@wesruv wesruv mentioned this issue Feb 19, 2018
Merged
@quicksketch
Copy link
Member

I rerolled backdrop/backdrop#1625 and added an extra selector to target long text fields as well.

backdrop-ci referenced this issue in backdrop/backdrop May 24, 2018
@quicksketch
Issue #2295: Clearfix rich text areas in case of floated content.
f0f7cb4 
By @wesruv and @quicksketch.
@quicksketch
Copy link
Member

quicksketch commented May 24, 2018 •
edited
Loading

Merged backdrop/backdrop#1625 into 1.x and 1.10.x.

backdrop-ci referenced this issue in backdrop/backdrop May 24, 2018
@quicksketch
Issue #2295: Clearfix rich text areas in case of floated content.
cd7855e 
By @wesruv and @quicksketch.
@quicksketch quicksketch added this to the 1.10.1 milestone May 24, 2018
@jenlampton jenlampton mentioned this issue May 30, 2018
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status - fixed type - bug report
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
2 participants
@quicksketch @wesruv