Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Remove "Provide markup text for the area." text in views #2757

Closed
jenlampton opened this issue Jul 1, 2017 · 3 comments
Closed

[UX] Remove "Provide markup text for the area." text in views #2757

jenlampton opened this issue Jul 1, 2017 · 3 comments
Labels
good first issue status - fixed status - has pull request
Milestone
1.8.2

Comments

@jenlampton
Copy link
Member

jenlampton commented Jul 1, 2017 •
edited by serundeputy

Describe your issue or idea

In the views global custom text settings form, there is a element that simply shows the text Provide markup text for the area.. These words make no sense to me. Is this supposed to be explaining what "Global: Text area" means? If so, it's doing a poor job. Let's fix it :)

screen shot 2017-06-30 at 5 55 48 pm

PR by @GianniCoene : backdrop/backdrop#2063
@GianniCoene
Copy link

Hello, I would like to work on this issue for my first Open Source contribution.

@GianniCoene GianniCoene mentioned this issue Jan 5, 2018
Merged
@jenlampton
Copy link
Member Author

jenlampton commented Jan 5, 2018 •
edited

Hi @GianniCoene and thanks for tackling this one :) Your fix looks great! Marking as RTBC.

@jenlampton jenlampton added this to the 1.8.2 milestone Jan 5, 2018
backdrop-ci referenced this issue in backdrop/backdrop Jan 12, 2018
@GianniCoene @serundeputy
Issue #2757: Removed "Provide markup text for the area." text in views.
6de4323
@serundeputy
Copy link
Member

This is great @GianniCoene thanks so much for your first open source contribution!
@jenlampton thanks for the RTBC!

This is merged into 1.x and 1.8.x and will ship with 1.9.0 and 1.8.2.

backdrop-ci referenced this issue in backdrop/backdrop Jan 12, 2018
@GianniCoene @serundeputy
Issue #2757: Removed "Provide markup text for the area." text in views.
fde5792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue status - fixed status - has pull request
Projects
None yet
Milestone
1.8.2
Development

No branches or pull requests
3 participants
@jenlampton @serundeputy @GianniCoene